-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forced Fourier
class to output contiguous tensors.
#7969
Conversation
Fourier
class to output contiguous() tensors.Fourier
class to output contiguous tensors.
Hi @bwittmann, do you plan to finish this PR? If we want to include the change in version 1.4, we only have about one or two weeks left to add new things. |
Dear @KumoLiu, following your recommendation, I added Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM.
Hi @bwittmann, please help fix the DCO and format issue. Thanks. |
DCO Remediation Commit for Bastian Wittmann <bastian.wittmann@uzh.ch> I, Bastian Wittmann <bastian.wittmann@uzh.ch>, hereby add my Signed-off-by to this commit: fb65555 I, Bastian Wittmann <bastian.wittmann@uzh.ch>, hereby add my Signed-off-by to this commit: 4df5947 Signed-off-by: Bastian Wittmann <bastian.wittmann@uzh.ch>.
You can refer to the instruction here to fix the DCO issue. |
I, Bastian Wittmann <bastian.wittmann@uzh.ch>, hereby add my Signed-off-by to this commit: 24c195a Signed-off-by: Bastian Wittmann <bastian.wittmann@uzh.ch>
/build |
Forced
Fourier
class to output contiguous tensors, which potentially fixes a performance bottleneck.Description
Some transforms, such as
RandKSpaceSpikeNoise
, rely on theFourier
class.In its current state, the
Fourier
class returns non-contiguous tensors, which potentially limits performance.For example, when followed by
RandHistogramShift
, the following warning occurs:A straightforward fix is to force the
Fourier
class to output contiguous tensors (see commit).To reproduce, please run:
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.