-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generalized dice computation #7970
Conversation
Signed-off-by: Suraj Pai <bspai@bwh.harvard.edu> Similar functionality to torchmetrics Update Lint and update sum_over_labels Update docstring Update docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, overall looks good to me.
Once you finished the PR, please let me know, I will add more people help review it, thanks.
Hi @surajpaib, do you plan to address the comments on the PR? I’m hoping we can get this merged into version 1.4, but we only have about one or two weeks left to add new features. |
Hi @KumoLiu, sorry for the gap, was away on vacation. I think I can work on this in the next few days and get it in. |
@KumoLiu I've incorporated the comments we discussed.
The tests seem to be failing because of the version string - I assume we can set this appropriately during the release. Let me know if you see any other changes |
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Suraj Pai <b.pai@maastrichtuniversity.nl>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Suraj Pai <b.pai@maastrichtuniversity.nl>
Signed-off-by: Suraj Pai <bspai@bwh.harvard.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM.
Could you please help fix the ci issue and dco issue then I can help trigger more tests and merge this one?
https://github.com/Project-MONAI/MONAI/actions/runs/10733660015/job/29767399315?pr=7970#step:7:428
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Suraj Pai <b.pai@maastrichtuniversity.nl>
Hi @surajpaib, you can fix the dco issue by following the method here: https://github.com/Project-MONAI/MONAI/pull/7970/checks?check_run_id=29787940944 |
_________ DCO Remediation Commit for Suraj Pai <bspai@bwh.harvard.edu> I, Suraj Pai <bspai@bwh.harvard.edu>, hereby add my Signed-off-by to this commit: 2081cd2 I, Suraj Pai <bspai@bwh.harvard.edu>, hereby add my Signed-off-by to this commit: 3805fea I, Suraj Pai <bspai@bwh.harvard.edu>, hereby add my Signed-off-by to this commit: fb6e660 I, Suraj Pai <bspai@bwh.harvard.edu>, hereby add my Signed-off-by to this commit: 8274060 Signed-off-by: Suraj Pai <bspai@bwh.harvard.edu>
Signed-off-by: Suraj Pai <bspai@bwh.harvard.edu>
Signed-off-by: Suraj Pai <bspai@bwh.harvard.edu>
/build |
Fixes Project-MONAI#7966 ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Suraj Pai <b.pai@maastrichtuniversity.nl> Signed-off-by: Suraj Pai <bspai@bwh.harvard.edu> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Fixes #7966
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.