Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running integration test within VS #239

Merged
merged 32 commits into from
Nov 10, 2022
Merged

Enable running integration test within VS #239

merged 32 commits into from
Nov 10, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 6, 2022

Description

  • Changes made to make running integration test easier without using bash script.
  • Enables running integration test within VS Test Explorer (with all 3rd party services running as provided in the docker-compose template).

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

mocsharp and others added 8 commits November 2, 2022 20:45
- Removes sqlite from docker image

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the testing Automated Tests, Unit Tests label Nov 6, 2022
@mocsharp mocsharp added this to the 0.3.4 milestone Nov 6, 2022
@mocsharp mocsharp self-assigned this Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #239 (d5e9945) into develop (697c7fc) will decrease coverage by 0.02074%.
The diff coverage is 77.77778%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #239         +/-   ##
===================================================
- Coverage   87.17347%   87.15273%   -0.02074%     
===================================================
  Files            276         276                 
  Lines          16193       16198          +5     
  Branches         835         835                 
===================================================
+ Hits           14116       14117          +1     
- Misses          1818        1822          +4     
  Partials         259         259                 
Flag Coverage Δ
unittests 87.15273% <77.77778%> (-0.02074%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/InformaticsGateway/Test/DummyMessagingService.cs 28.57143% <ø> (ø)
...maticsGateway/Services/Export/ExportServiceBase.cs 85.80247% <60.00000%> (-0.82174%) ⬇️
src/InformaticsGateway/Services/Scp/ScpService.cs 86.04651% <100.00000%> (ø)
...y/Test/Services/Connectors/PayloadAssemblerTest.cs 98.90110% <100.00000%> (ø)
...maticsGateway/Services/HealthLevel7/MllpService.cs 76.92308% <0.00000%> (-1.09891%) ⬇️
...ateway/Services/Connectors/DataRetrievalService.cs 80.00000% <0.00000%> (-0.35715%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697c7fc...d5e9945. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Base automatically changed from gh-235 to develop November 8, 2022 18:50
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested a review from neildsouth November 10, 2022 16:19
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 9a0a705 into develop Nov 10, 2022
@mocsharp mocsharp deleted the vchang/e2e branch November 10, 2022 17:49
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.4 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Automated Tests, Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants