Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation for AET, IP & hostnames/domain names #261

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 17, 2022

Description

Update validation logic for AET, IP address and hostnames/domain names.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Nov 17, 2022
@mocsharp mocsharp added this to the 0.3.4 milestone Nov 17, 2022
@mocsharp mocsharp self-assigned this Nov 17, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #261 (78a9cea) into develop (ff677ce) will increase coverage by 0.01964%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #261         +/-   ##
===================================================
+ Coverage   81.82181%   81.84145%   +0.01963%     
===================================================
  Files            304         304                 
  Lines          17554       17584         +30     
  Branches         883         883                 
===================================================
+ Hits           14363       14391         +28     
- Misses          2920        2921          +1     
- Partials         271         272          +1     
Flag Coverage Δ
unittests 81.84145% <100.00000%> (+0.01963%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Configuration/Test/ValidationExtensionsTest.cs 100.00000% <100.00000%> (ø)
src/Configuration/ValidationExtensions.cs 93.75000% <100.00000%> (+0.89285%) ⬆️
...ateway/Services/Connectors/DataRetrievalService.cs 80.64516% <0.00000%> (-0.71685%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff677ce...78a9cea. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested a review from samrooke November 18, 2022 16:09
@mocsharp mocsharp merged commit 777473e into develop Nov 18, 2022
@mocsharp mocsharp deleted the gh-246 branch November 18, 2022 17:00
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.4 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
Development

Successfully merging this pull request may close these issues.

2 participants