Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record associations to the database #263

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Record associations to the database #263

merged 2 commits into from
Nov 23, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 18, 2022

Description

Record DICOM association info in the database.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp self-assigned this Nov 18, 2022
@mocsharp mocsharp added the enhancement Enhancement to existing feature label Nov 18, 2022
@mocsharp mocsharp added this to the 0.3.4 milestone Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #263 (e7bb167) into develop (0749690) will decrease coverage by 1.41181%.
The diff coverage is 35.75419%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #263         +/-   ##
===================================================
- Coverage   85.49431%   84.08250%   -1.41182%     
===================================================
  Files            312         321          +9     
  Lines          18379       18910        +531     
  Branches         895         906         +11     
===================================================
+ Hits           15713       15900        +187     
- Misses          2370        2709        +339     
- Partials         296         301          +5     
Flag Coverage Δ
unittests 84.08250% <35.75419%> (-1.41182%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ork/Migrations/20221123174502_R3_0.3.5.Designer.cs 0.00000% <0.00000%> (ø)
...ityFramework/Migrations/20221123174502_R3_0.3.5.cs 0.00000% <0.00000%> (ø)
...grations/InformaticsGatewayContextModelSnapshot.cs 0.00000% <0.00000%> (ø)
src/Database/DatabaseManager.cs 40.74074% <50.00000%> (+0.74074%) ⬆️
...ork/Repositories/DicomAssociationInfoRepository.cs 68.75000% <68.75000%> (ø)
...oDB/Repositories/DicomAssociationInfoRepository.cs 71.87500% <71.87500%> (ø)
...ormaticsGateway/Services/Scp/ScpServiceInternal.cs 77.31959% <77.27273%> (+1.00379%) ⬆️
...amework/Test/DicomAssociationInfoRepositoryTest.cs 97.29730% <97.29730%> (ø)
...gration.Test/DicomAssociationInfoRepositoryTest.cs 97.43590% <97.43590%> (ø)
src/Api/DicomAssociationInfo.cs 100.00000% <100.00000%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0749690...e7bb167. Read the comment docs.

@mocsharp mocsharp removed this from the 0.3.4 milestone Nov 21, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/associations branch from f4f87f9 to e7bb167 Compare November 23, 2022 17:47
@mocsharp mocsharp added this to the 0.3.5 milestone Nov 23, 2022
@mocsharp mocsharp merged commit 438faee into develop Nov 23, 2022
@mocsharp mocsharp deleted the vchang/associations branch November 23, 2022 18:30
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

🎉 This issue has been resolved in version 0.3.5 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants