Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate MONAI Deploy Security to enable API auth #276

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Dec 2, 2022

Description

Fixes #47

Enable auth with OIDC

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the security Security label Dec 2, 2022
@mocsharp mocsharp added this to the 0.3.5 milestone Dec 2, 2022
@mocsharp mocsharp self-assigned this Dec 2, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #276 (a9201f2) into develop (438faee) will increase coverage by 0.01394%.
The diff coverage is 92.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #276         +/-   ##
===================================================
+ Coverage   84.08778%   84.10172%   +0.01394%     
===================================================
  Files            321         321                 
  Lines          18910       18914          +4     
  Branches         906         906                 
===================================================
+ Hits           15901       15907          +6     
+ Misses          2709        2707          -2     
  Partials         300         300                 
Flag Coverage Δ
unittests 84.10172% <92.00000%> (+0.01394%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/InformaticsGateway/Test/DummyStorageService.cs 9.52381% <0.00000%> (ø)
...ay/Services/Connectors/PayloadMoveActionHandler.cs 78.29457% <50.00000%> (ø)
src/InformaticsGateway/Services/Http/Startup.cs 80.85106% <88.88889%> (+1.30561%) ⬆️
...c/Configuration/Test/ConfigurationValidatorTest.cs 100.00000% <100.00000%> (ø)
...icsGateway/Common/FileStorageMetadataExtensions.cs 92.30769% <100.00000%> (-7.69232%) ⬇️
src/InformaticsGateway/Program.cs 83.78378% <100.00000%> (-0.42676%) ⬇️
...icsGateway/Services/Storage/ObjectUploadService.cs 60.16260% <100.00000%> (-0.94851%) ⬇️
...t/Common/DicomFileStorageMetadataExtensionsTest.cs 100.00000% <100.00000%> (ø)
...ervices/Connectors/PayloadMoveActionHandlerTest.cs 100.00000% <100.00000%> (ø)
...eway/Test/Services/HealthLevel7/MllpServiceTest.cs 100.00000% <100.00000%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438faee...a9201f2. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 42f06c6 into develop Dec 6, 2022
@mocsharp mocsharp deleted the gh-47 branch December 6, 2022 16:52
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

🎉 This issue has been resolved in version 0.3.5 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth & LDAP integration
3 participants