Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record user access to POST (create) /PUT (edit) API calls in database #291

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Dec 14, 2022

Description

Fixes #288

Stores CreatedBy, UpdatedBy and DateTimeCreated, DateTimeUpdated when the following APIs are called:

  • POST /config/ae
  • PUT /config/ae
  • POST /config/source
  • PUT /config/source
  • POST /config/destination
  • PUT /config/destination
  • POST /inference

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Dec 14, 2022
@mocsharp mocsharp added this to the 0.3.6 milestone Dec 14, 2022
@mocsharp mocsharp self-assigned this Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #291 (adcaeb6) into develop (4c7c599) will decrease coverage by 2.07309%.
The diff coverage is 18.58553%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #291         +/-   ##
===================================================
- Coverage   84.05031%   81.97722%   -2.07309%     
===================================================
  Files            321         323          +2     
  Lines          18922       19492        +570     
  Branches         909         915          +6     
===================================================
+ Hits           15904       15979         +75     
- Misses          2713        3207        +494     
- Partials         305         306          +1     
Flag Coverage Δ
unittests 81.97722% <18.58553%> (-2.07309%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/DicomAssociationInfo.cs 100.00000% <ø> (ø)
src/Api/LoggingDataDictionary.cs 66.66667% <ø> (ø)
src/Api/Rest/InferenceRequestDetails.cs 100.00000% <ø> (ø)
src/Api/Storage/DicomFileStorageMetadata.cs 97.22222% <ø> (ø)
src/Api/Storage/FhirFileStorageMetadata.cs 100.00000% <ø> (ø)
src/Api/Storage/FileStorageMetadata.cs 100.00000% <ø> (ø)
src/Api/Storage/Hl7FileStorageMetadata.cs 91.66667% <ø> (ø)
src/CLI/Commands/SourceCommand.cs 98.69281% <ø> (ø)
src/CLI/Test/DestinationCommandTest.cs 100.00000% <ø> (ø)
src/CLI/Test/SourceCommandTest.cs 100.00000% <ø> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7c599...adcaeb6. Read the comment docs.

@mocsharp mocsharp force-pushed the vchang/gh-288 branch 2 times, most recently from 9c067e0 to ff8efda Compare December 15, 2022 00:05
@mocsharp mocsharp changed the title Record username in database POST (create) /PUT (edit) API calls Record user access to POST (create) /PUT (edit) API calls in database Dec 15, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested a review from neildsouth December 15, 2022 01:04
@mocsharp mocsharp merged commit 3252f40 into develop Dec 15, 2022
@mocsharp mocsharp deleted the vchang/gh-288 branch December 15, 2022 16:01
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.6 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to save user details to mongo for export destination and AET
2 participants