change to logging #466
Merged
change to logging #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #466 +/- ##
===================================================
- Coverage 80.09275% 80.02254% -0.07021%
===================================================
Files 379 379
Lines 23936 23957 +21
Branches 1081 1083 +2
===================================================
Hits 19171 19171
- Misses 4394 4412 +18
- Partials 371 374 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here. |
mocsharp
reviewed
Sep 6, 2023
mocsharp
reviewed
Sep 8, 2023
| @@ -70,5 +70,6 @@ | |||
| <PackageReference Include="AspNetCore.HealthChecks.MongoDb" Version="6.0.2" /> | |||
| <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore" Version="6.0.21" /> | |||
| <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="6.0.0" /> | |||
| <PackageReference Include="NLog.Web.AspNetCore" Version="5.3.3" /> | |||
There was a problem hiding this comment.
Is this needed since this project doens't reference any ASP.NET lib.
There was a problem hiding this comment.
not sure how that got added. will remove
mocsharp
reviewed
Sep 8, 2023
| @@ -55,9 +55,9 @@ public static Type GetType(this Type interfaceType, string typeString) | |||
| typeString, | |||
| (name) => | |||
| { | |||
| var assembly = AppDomain.CurrentDomain.GetAssemblies().FirstOrDefault(z => !string.IsNullOrWhiteSpace(z.FullName) && z.FullName.StartsWith(name.FullName)); | |||
| var assembly = AppDomain.CurrentDomain.GetAssemblies().ToList().Find(z => !string.IsNullOrWhiteSpace(z.FullName) && z.FullName.StartsWith(name.FullName)); | |||
There was a problem hiding this comment.
Doesn't .ToList().Find(...) take extra execution?
There was a problem hiding this comment.
This was to stop a warning, but Im going to change it back.
mocsharp
approved these changes
Sep 8, 2023
Signed-off-by: Neil South <neil.south@answerdigital.com>
neildsouth
force-pushed
the
AI94-nds-logging
branch
from
9528da3 to
c9c584c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to logging
Status
Ready
Types of changes