Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ai 357 #505

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Ai 357 #505

merged 4 commits into from
Jan 19, 2024

Conversation

neildsouth
Copy link
Contributor

@neildsouth neildsouth commented Dec 13, 2023

Description

adding more logging

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (79c3e53) 65.39580% compared to head (4a7a86f) 65.36263%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #505         +/-   ##
===================================================
- Coverage   65.39580%   65.36263%   -0.03317%     
===================================================
  Files            374         374                 
  Lines          21324       21344         +20     
  Branches        1331        1332          +1     
===================================================
+ Hits           13945       13951          +6     
- Misses          6874        6885         +11     
- Partials         505         508          +3     
Flag Coverage Δ
unittests 65.36263% <68.00000%> (-0.03317%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Api/Storage/Hl7FileStorageMetadata.cs 93.75000% <ø> (ø)
...csGateway/Services/Common/InputDataPluginEngine.cs 100.00000% <100.00000%> (ø)
...icsGateway/Services/Connectors/PayloadAssembler.cs 84.70588% <100.00000%> (ø)
...ces/Connectors/PayloadNotificationActionHandler.cs 84.82143% <100.00000%> (+0.13675%) ⬆️
...rmaticsGateway/Services/Export/Hl7ExportService.cs 93.44262% <100.00000%> (ø)
...ticsGateway/Test/Plug-ins/TestInputHL7DataPlugs.cs 85.71429% <100.00000%> (+5.71429%) ⬆️
src/InformaticsGateway/Program.cs 80.83333% <0.00000%> (-0.67928%) ⬇️
...ateway/Services/Common/InputHL7DataPlugInEngine.cs 96.15385% <85.71429%> (-3.84615%) ⬇️
...maticsGateway/Services/HealthLevel7/MllpExtract.cs 70.31250% <80.00000%> (+0.47123%) ⬆️
...maticsGateway/Services/HealthLevel7/MllpService.cs 53.50318% <57.14286%> (+0.29805%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c3e53...4a7a86f. Read the comment docs.

@neildsouth neildsouth added this to the 0.5.0 milestone Jan 8, 2024
@neildsouth neildsouth added the enhancement Enhancement to existing feature label Jan 8, 2024
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth merged commit eb841e4 into develop Jan 19, 2024
29 of 31 checks passed
@neildsouth neildsouth deleted the AI-357 branch January 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants