Use M1 runner to build arm64 macOS builds #6868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
force-pushed
the
sf-macos-arm64
branch
from
a74f010
to
07590b4
Compare
SiarheiFedartsou
changed the title
|
Nice, looks like this is much cleaner than #6864. |
Ah sorry, I haven’t noticed your PR when started working on this… |
SiarheiFedartsou
commented
May 7, 2024
| @@ -331,7 +331,7 @@ jobs: | |||
| build_node_package: true | |||
| continue-on-error: true | |||
| node: 20 | |||
| runs-on: macos-11 | |||
| runs-on: macos-13 # x86_64 | |||
There was a problem hiding this comment.
Looking at #6864 it seems we can use macos-14-large here, right @DennisOSRM ?
There was a problem hiding this comment.
Yes, that should probably work.
No worries. Great minds think alike. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
GitHub now provides M1 based runner, so we can use it actions/runner-images#9254
Besides that I had to update Boost to version 1.85.0, because otherwise we had compilation errors on this new macOS.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?