Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Swedish #138

Merged
merged 4 commits into from
Aug 25, 2017
Merged

Updated Swedish #138

merged 4 commits into from
Aug 25, 2017

Conversation

davols
Copy link
Contributor

@davols davols commented Aug 25, 2017

Issue

What Github issue is this PR targeting?
Regarding issue #136 - Moved to another PR in order to keep a discussion regarding the changes in here instead.

Misc

Removed the adjectives for turns in transifex. Default for turn works for all entries except for uturns.
cc @frederoni @1ec5

David Olsson added 2 commits August 25, 2017 09:29
… that it still is incorrect for uturn. Also removed the adjectives for slight and sharp since they are (never?) used irl in Swedish. Shortening roundabouts and uturns. Fixed the grammar for exits and exit_numbers
@@ -165,24 +165,24 @@
"destination": "Körfältsbyte åt {modifier} mot {destination}"
Copy link
Contributor

@frederoni frederoni Aug 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change these too or would the definite form adjective make it clash with the noun?
Something like {modifier.definiteForm} vänster/vänstra would be convenient.

Copy link
Contributor Author

@davols davols Aug 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to change these too. But I'm not aware if it's even possible. Since the modifier needs to be vänster for other instructions. Guess there is no way to extend the modifier to have a form too? But this should be changed since it's an instruction without a verb.

Edit: Adding a new change. 'Byt till modifier körfält' which would work ok for vänster/höger.

@frederoni
Copy link
Contributor

This reads so much better. Great job.
I think you have to update the test fixtures UPDATE=1 npm test and commit the changes.

@davols
Copy link
Contributor Author

davols commented Aug 25, 2017

I think you have to update the test fixtures UPDATE=1 npm test and commit the changes.

Will do, saw the fail CI. Checked some other closed PRs for updated languages and they didn't seem to have the textures. But adding them now.

@davols
Copy link
Contributor Author

davols commented Aug 25, 2017

Some future improvements I guess would be:

  • Have definite form for modifiers
  • have a specific string for turn.uturn (see below)
    turn with something else than strict turn.left & turn.right reads correct except for only turn.uturn - the only way to fix that (?) would be to change turn.default but that would break everything except uturn. So either 4 incorrect strings or 1.

@1ec5
Copy link
Member

1ec5 commented Aug 25, 2017

Thank you for these improvements, @davols! We can track further improvements in #136 and Transifex.

@1ec5 1ec5 merged commit 4dda2da into Project-OSRM:master Aug 25, 2017
1ec5 added a commit that referenced this pull request Aug 25, 2017
- Adds Brazilian Portuguese, Italian, and Ukrainian localizations. #137
- Adds the word “right” to right-hand exit instructions. #125
- Improves the wording of “continue straight” instructions. #130
- Improves the wording of various instructions in Russian and Swedish. #138
- The Spanish localization consistently uses usted form. #137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants