-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Swedish #138
Updated Swedish #138
Conversation
… that it still is incorrect for uturn. Also removed the adjectives for slight and sharp since they are (never?) used irl in Swedish. Shortening roundabouts and uturns. Fixed the grammar for exits and exit_numbers
languages/translations/sv.json
Outdated
@@ -165,24 +165,24 @@ | |||
"destination": "Körfältsbyte åt {modifier} mot {destination}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change these too or would the definite form adjective make it clash with the noun?
Something like {modifier.definiteForm} vänster/vänstra would be convenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to change these too. But I'm not aware if it's even possible. Since the modifier needs to be vänster
for other instructions. Guess there is no way to extend the modifier to have a form too? But this should be changed since it's an instruction without a verb.
Edit: Adding a new change. 'Byt till modifier körfält' which would work ok for vänster/höger.
This reads so much better. Great job. |
Will do, saw the fail CI. Checked some other closed PRs for updated languages and they didn't seem to have the textures. But adding them now. |
Some future improvements I guess would be:
|
- Adds Brazilian Portuguese, Italian, and Ukrainian localizations. #137 - Adds the word “right” to right-hand exit instructions. #125 - Improves the wording of “continue straight” instructions. #130 - Improves the wording of various instructions in Russian and Swedish. #138 - The Spanish localization consistently uses usted form. #137
Issue
What Github issue is this PR targeting?
Regarding issue #136 - Moved to another PR in order to keep a discussion regarding the changes in here instead.
Misc
Removed the adjectives for turns in transifex. Default for turn works for all entries except for uturns.
cc @frederoni @1ec5