Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename traffic circle to roundabout #285

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Rename traffic circle to roundabout #285

merged 2 commits into from
Jul 23, 2019

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Jul 23, 2019 •
edited
Loading

Issue

The English localization now calls all circular junctions “roundabouts”. There is no longer a quaint BosWash distinction between classical roundabouts as “traffic circles” and modern roundabouts as “roundabouts” (which in practice meant roundabouts were always called “traffic circles”).

Fixes #188 and reverts #179.

Tasklist

  • Modernize English vocabulary
  • Add changelog entry
  • Test with osrm-frontend (?)
  • Review
  • Test drive around and around

Requirements / Relations

Same as #256, plus one year and minus the American English overrides. If an American English localization mechanism is needed in the future, we can resurrect that part of #256.

/cc @danpaz @dgearhart

@1ec5 1ec5 requested a review from danpaz July 23, 2019 20:30
@1ec5 1ec5 self-assigned this Jul 23, 2019
@1ec5 1ec5 mentioned this pull request Jul 23, 2019
Closed
5 tasks
@1ec5
Copy link
Member Author

1ec5 commented Jul 23, 2019

Some languages like Esperanto will need to be updated to use the more usual word for “roundabout” instead of a literal translation of “traffic circle”: #188 (comment). But that can happen independently of this PR.

danpaz
danpaz approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@danpaz danpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we circled back on this. Approved.

@1ec5 1ec5 merged commit c4f147e into master Jul 23, 2019
@1ec5 1ec5 deleted the 1ec5-merry-go-roundabout-188-2 branch July 23, 2019 20:42
danpaz added a commit that referenced this pull request Sep 16, 2019
@danpaz
v0.13.4
5b6a700 
- Added a Yoruba localization. [#284](#284)
- Renamed “traffic circle” to “roundabout” in the English localization. [#285](#285)
- Rewrote the Burmese localization. [#282](#282)
- Fixed typographical errors in Italian. [#281](#281)
- Fixed grammatical errors in Danish. [#286](#286)
@danpaz danpaz mentioned this pull request Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpaz danpaz danpaz approved these changes

Assignees

@1ec5 1ec5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename traffic circles to roundabouts
2 participants
@1ec5 @danpaz