Named intersections #291
Named intersections #291
Conversation
danpaz
force-pushed
the
named_intersections
branch
2 times, most recently
from
9976e77
to
7a991bd
Compare
danpaz
force-pushed
the
named_intersections
branch
from
7a991bd
to
3d20ccd
Compare
| // - junction name | ||
| // - road name | ||
| // - waypoint name (for arrive maneuver) | ||
| // - default |
languages/translations/ru.json
Outdated
| @@ -166,17 +166,20 @@ | |||
| "default": { | |||
| "default": "Поверните {modifier}", | |||
| "name": "Поверните {modifier} на {way_name:accusative}", | |||
| "destination": "Поверните {modifier} в направлении {destination}" | |||
| "destination": "Поверните {modifier} в направлении {destination}", | |||
| "junction_name": "Turn {modifier} at {junction_name}" | |||
There was a problem hiding this comment.
Based on the key junction_name, it sounds like we don’t expect this particular string to be repurposed for destination-based instructions in the future, correct? Since this feature is primarily going to be used in Japan and South Korea, we probably don’t need to worry all that much about cases and declension in languages like Russian, though perhaps grammar rules may eventually be needed for the articles in French.
There was a problem hiding this comment.
Actually this will be already prepared prepositional grammar case in Russian 😉 But I'm not sure what changes will be necessary for Hungarian (@kiskunk) and perhaps Danish (@cmahopper)?
languages/translations/en.json
Outdated
| }, | ||
| "uturn": { | ||
| "default": "Make a U-turn at the end of the road", | ||
| "name": "Make a U-turn onto {way_name} at the end of the road", | ||
| "destination": "Make a U-turn towards {destination} at the end of the road" | ||
| "destination": "Make a U-turn towards {destination} at the end of the road", | ||
| "junction_name": "Make a U-turn at {junction_name} at the end of the road" |
There was a problem hiding this comment.
end of road instructions were introduced as a user convenience, so that the user would know they didn’t need to keep track of the remaining distance and could focus on reaching the end of the road. It may be desirable to avoid overloading the user with both the junction name and the “end of road” phrase.
There was a problem hiding this comment.
Agree, updated in a4d2423.
|
Well for the hungarian version we had to write our own translator engine, since there were way too many grammar rules and problems. So now we use the english version then pass it to our translator java. I have no idea how it could be implemented in OSRM. |
| @@ -132,27 +132,32 @@ | |||
| "sharp left": { | |||
| "default": "Quẹo gắt bên trái", | |||
| "name": "Quẹo gắt bên trái để chạy tiếp trên {way_name}", | |||
| "destination": "Quẹo gắt bên trái về {destination}" | |||
| "destination": "Quẹo gắt bên trái về {destination}", | |||
| "junction_name": "Quẹo gắt bên trái ở {junction_name}" | |||
There was a problem hiding this comment.
👍 I think the more natural way to say this in Vietnamese would be “Đến {junction_name} quẹo gắt bên trái”. (There are a few famous intersections in Ho Chi Minh City that would get this treatment for sure.) However, in turn-by-turn guidance, it’s more effective to say the maneuver direction before ancillary details like road or junction names, as this translation does.
Issue
Branches off #290 as both PRs relate primarily to Japanese guidance.
For routing in Japan and Korea, it's typical to have junctions with names announced in navigation instructions, e.g. "Turn right at Shibuya Crossing" rather than road names. See https://wiki.openstreetmap.org/wiki/Named_spots_instead_of_street_names.
@tsuz @YoshiYazawa @tichimura for review of the Japanese phrases.
Tasklist
Requirements / Relations