Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Persian (Iran) language #301

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Persian (Iran) language #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c58259
Add Persian (Iran) language
Feb 3, 2021
052d5b8
JSON first char and UTF-8 correct
Feb 3, 2021
0a8e656
Delete package-lock.json
Mahdi-Farhani Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion languages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ var instructionsUk = require('./languages/translations/uk.json');
var instructionsVi = require('./languages/translations/vi.json');
var instructionsYo = require('./languages/translations/yo.json');
var instructionsZhHans = require('./languages/translations/zh-Hans.json');
var instructionsFaIr = require('./languages/translations/fa-IR.json');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This localization should be under the language code fa, not fa-IR. We shouldn’t add a localization specific to Iran until we have one that covers the Persian language regardless of the country. Otherwise, clients that don’t specify the country or that specify a different country won’t be able to pick up this localization at all. There may eventually be a need to split out a separate fa-IR localization, in order to account for any differences in terminology that are common in Iran but not abroad. However, this would be a premature step for now.

I’m not sure who approved the request to add the fa-IR localization on Transifex, but the translations there should be merged with the localization for fa that was started there. If you need access to that localization in order to complete it, please put in a request to join the translation team. Thanks!


// Load all grammar files
var grammarDa = require('./languages/grammar/da.json');
Expand Down Expand Up @@ -86,7 +87,8 @@ var instructions = {
'uk': instructionsUk,
'vi': instructionsVi,
'yo': instructionsYo,
'zh-Hans': instructionsZhHans
'zh-Hans': instructionsZhHans,
'fa-IR': instructionsFaIr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add your language code in alphabet order not to the the end of the list 😉

};

// Create list of supported grammar
Expand Down
Loading