Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_timestamp called during Dataset build should be exploded #209

Closed
Gautzilla opened this issue Oct 15, 2024 · 0 comments · Fixed by #210
Closed

write_timestamp called during Dataset build should be exploded #209

Gautzilla opened this issue Oct 15, 2024 · 0 comments · Fixed by #210
Assignees
Labels
short term Issue that takes a short time to be corrected

Comments

@Gautzilla
Copy link
Contributor

This function:

  • Includes both timestamp operations and audio file validation functions
  • Has some edgy features (.WAV and .FLAC extensions are tested only if there is no .wav or .flac extensions in the folder)
  • Probably could only use pandas.Timestamp features instead of relying on regular expressions
  • Should be split up in separate functions with both unit and integration testing, located in appropriate utils folders
  • The test_create_timestamps.py associated test file should cover a larger scope
@Gautzilla Gautzilla added the short term Issue that takes a short time to be corrected label Oct 15, 2024
@Gautzilla Gautzilla self-assigned this Oct 15, 2024
@Gautzilla Gautzilla linked a pull request Oct 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short term Issue that takes a short time to be corrected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant