-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor timestamps managing #210
refactor timestamps managing #210
Conversation
@mathieudpnt @cazaudo, basically this PR does: A rework of how the timestamps are parsed from the audio file names. I added some basic utils which might simplify the old
I added a bunch of unit and integration tests to make the thing robust, and it should not break the global (untested) OSEkit workflow since the timestamp.csv is written in the same fashion as before (except for the timestamp precision, which has been reduced to the millisecond). I intentionally kept the The utils added to timestamp_utils should also be used elsewhere in the codebase (e.g. by the reshaper), I'll do that in the near future too. PS: pytest throws some warnings on the Python 3.10 used in the github actions here. I managed to solve them locally in an environment that uses Python 3.12.7: is there a reason for sticking with the 3.10 version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor changes, overall looks good to me!
This PR follows the changes made regarding issue #209