Hotfix/check permissions before chmod #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix a bug where OSEkit unnecessarily tries to change folders/files for which it already has write/read accesses but for which it doesn't have the permission to change the permissions.
Basically, the
os.chmod
function should now only be called if the user doesn't have the read and write permissions to the file or folder.@cazaudo: In the
Spectrogram
class, 2 files permissions were changed to theDPDEFAULT
mode:Line
1050
Line
1065
I changed the modes to
FPDEFAULT
, and added a comment to keep track of that:I'll remove the comment if you validate that the mode should be
FPDEFAULT
, or change back toDPDEFAULT