Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup. #106

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Small cleanup. #106

merged 3 commits into from
Feb 8, 2023

Conversation

TehSteel
Copy link
Contributor

Small cleanup.

Changed GetDistanceBetweenCoords to lua math check.
Changed table.insert and table.remove to tableName[#tableName+1] = whatever and tableName[id] = nil.
Made models after spawning to unload from memory using SetModelAsNoLongerNeeded.

@Andyauk
Copy link
Contributor

Andyauk commented Jan 19, 2023

not fully tested it. but you do have an error @ps-drugprocessing/client/sulfuricacid.lua:87
change from
if #(coords - GetEntityCoords(SulfuricAcidBarrels[i])) < 2
to
if #(coords - GetEntityCoords(SulfuricAcidBarrels[i])) < 2 then

@TehSteel
Copy link
Contributor Author

not fully tested it. but you do have an error @ps-drugprocessing/client/sulfuricacid.lua:87 change from if #(coords - GetEntityCoords(SulfuricAcidBarrels[i])) < 2 to if #(coords - GetEntityCoords(SulfuricAcidBarrels[i])) < 2 then

Oopsy daisy, Fixed it 🥲

@MonkeyWhisper
Copy link
Member

Small cleanup.

Changed GetDistanceBetweenCoords to lua math check. Changed table.insert and table.remove to tableName[#tableName+1] = whatever and tableName[id] = nil. Made models after spawning to unload from memory using SetModelAsNoLongerNeeded.

Thanks for the cleanup, much needed, this resource is quite old already.

Are these changes live in a server and working as intended?

@TehSteel
Copy link
Contributor Author

TehSteel commented Feb 1, 2023

Small cleanup.
Changed GetDistanceBetweenCoords to lua math check. Changed table.insert and table.remove to tableName[#tableName+1] = whatever and tableName[id] = nil. Made models after spawning to unload from memory using SetModelAsNoLongerNeeded.

Thanks for the cleanup, much needed, this resource is quite old already.

Are these changes live in a server and working as intended?

No, Will put it tomorrow in a live server.

@Andyauk
Copy link
Contributor

Andyauk commented Feb 1, 2023

Small cleanup.
Changed GetDistanceBetweenCoords to lua math check. Changed table.insert and table.remove to tableName[#tableName+1] = whatever and tableName[id] = nil. Made models after spawning to unload from memory using SetModelAsNoLongerNeeded.

Thanks for the cleanup, much needed, this resource is quite old already.

Are these changes live in a server and working as intended?

I've had it in for just under 2 weeks no real issue. but I don't do everything. ill ask people of my city if they had any issues.

@TehSteel
Copy link
Contributor Author

TehSteel commented Feb 6, 2023

Small cleanup.
Changed GetDistanceBetweenCoords to lua math check. Changed table.insert and table.remove to tableName[#tableName+1] = whatever and tableName[id] = nil. Made models after spawning to unload from memory using SetModelAsNoLongerNeeded.

Thanks for the cleanup, much needed, this resource is quite old already.

Are these changes live in a server and working as intended?

Worked fine for me.

@Andyauk
Copy link
Contributor

Andyauk commented Feb 8, 2023

Small cleanup.
Changed GetDistanceBetweenCoords to lua math check. Changed table.insert and table.remove to tableName[#tableName+1] = whatever and tableName[id] = nil. Made models after spawning to unload from memory using SetModelAsNoLongerNeeded.

Thanks for the cleanup, much needed, this resource is quite old already.
Are these changes live in a server and working as intended?

Worked fine for me.

yes worked fine. tested all.

@MonkeyWhisper MonkeyWhisper merged commit 304744f into Project-Sloth:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants