-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding locales and notifications #43
Conversation
Adding locals to everything: Notifications, Target and Progressbars. Notifications added to picking and collecting stuff. I also removed some doubled code... (Removed prints)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Please review my comments :) I only have one concern.
Thank you so much for this PR, it'll be great for locales!!
fxmanifest.lua
Outdated
'config.lua', | ||
'@qb-core/shared/locale.lua', | ||
'locales/de.lua' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, English as default language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah, I'll change that. Wait for me to come home.
fixed requested things (default en.lua) and fixed some locales I misspelled...
Thanks a lot! |
Adding locals to everything: Notifications, Target and Progressbars.
Notifications added to picking and collecting stuff.
I also removed some doubled code...
(Removed prints)