Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding locales and notifications #43

Merged
merged 2 commits into from
May 3, 2022

Conversation

Flobbah
Copy link
Contributor

@Flobbah Flobbah commented May 1, 2022

Adding locals to everything: Notifications, Target and Progressbars.
Notifications added to picking and collecting stuff.
I also removed some doubled code...
(Removed prints)

Adding locals to everything: Notifications, Target and Progressbars.
Notifications added to picking and collecting stuff.
I also removed some doubled code...
(Removed prints)
Copy link
Member

@MonkeyWhisper MonkeyWhisper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Please review my comments :) I only have one concern.

Thank you so much for this PR, it'll be great for locales!!

client/target.lua Show resolved Hide resolved
server/lsd.lua Show resolved Hide resolved
server/meth.lua Outdated Show resolved Hide resolved
server/meth.lua Outdated Show resolved Hide resolved
fxmanifest.lua Outdated
'config.lua',
'@qb-core/shared/locale.lua',
'locales/de.lua'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, English as default language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah, I'll change that. Wait for me to come home.

fixed requested things (default en.lua) and fixed some locales I misspelled...
@Flobbah Flobbah requested a review from MonkeyWhisper May 3, 2022 19:14
@MonkeyWhisper
Copy link
Member

Thanks a lot!

@MonkeyWhisper MonkeyWhisper merged commit 0a627a4 into Project-Sloth:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants