Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Module Manager crash #69

Closed
oivio opened this issue Dec 6, 2022 · 10 comments
Closed

Some Module Manager crash #69

oivio opened this issue Dec 6, 2022 · 10 comments

Comments

@oivio
Copy link

oivio commented Dec 6, 2022

Assertion failed: Module [File:D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Modules\ModuleManager.cpp] [Line: 393] GitSourceControl

UnrealEditor_Core
UnrealEditor_GitSourceControl!GitSourceControlUtils::ParseFileStatusResult() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1065]
UnrealEditor_GitSourceControl!GitSourceControlUtils::ParseStatusResults() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1213]
UnrealEditor_GitSourceControl!GitSourceControlUtils::RunUpdateStatus() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1443]
UnrealEditor_GitSourceControl!FGitFetchWorker::Execute() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlOperations.cpp:689]
UnrealEditor_GitSourceControl!FGitSourceControlCommand::DoThreadedWork() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlCommand.cpp:46]
@mastercoms
Copy link
Member

How long was the editor running for?

@oivio
Copy link
Author

oivio commented Dec 6, 2022

How long was the editor running for?

It crash when I close the project. Right now editor was just running for around 5min.

@mastercoms
Copy link
Member

Okay, thanks, will fix this!

@oivio
Copy link
Author

oivio commented Dec 8, 2022

Another bad news. That just happen when I start the project.
What ever it is I, we really appreciate your amazing work. I am really surprised that Epic Games did not put official hands on it.


UnrealEditor_GitSourceControl!GitSourceControlUtils::CheckRemote() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1224]
UnrealEditor_GitSourceControl!GitSourceControlUtils::RunUpdateStatus() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1443]
UnrealEditor_GitSourceControl!<lambda_68a17c146a57dc8ff57889e495de7b03>::operator()() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlProvider.cpp:145]
UnrealEditor_GitSourceControl!<lambda_21ce35e8fe1f446dc4a0d1c30d994e62>::operator()() [G:\Projects\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlProvider.cpp:151]

@oivio
Copy link
Author

oivio commented Dec 8, 2022

Could possibly does Source Control Settings affect somehow? If I remember first 2 by default are unchecked. Maybe they make some complications that result in errors.
image

@mastercoms
Copy link
Member

Those should be fine, we also use them and I would recommend them to be honest. Third one we don't use.

mastercoms added a commit that referenced this issue Dec 8, 2022
@mastercoms
Copy link
Member

Let me know if this latest commit fixes the crashes

@oivio
Copy link
Author

oivio commented Dec 14, 2022

Sorry, I was away for a while. After downloading the latest updated I am getting still the same errors:

UnrealEditor_GitSourceControl!GitSourceControlUtils::ParseFileStatusResult() [E:\GitHub\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1065]
UnrealEditor_GitSourceControl!GitSourceControlUtils::ParseStatusResults() [E:\GitHub\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1213]
UnrealEditor_GitSourceControl!GitSourceControlUtils::RunUpdateStatus() [E:\GitHub\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1445]
UnrealEditor_GitSourceControl!FGitFetchWorker::Execute() [E:\GitHub\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlOperations.cpp:689]
UnrealEditor_GitSourceControl!FGitSourceControlCommand::DoThreadedWork() [E:\GitHub\ZHA\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlCommand.cpp:46]

I am using the latest UE 5.1 from Epic Launcher.

@mastercoms mastercoms reopened this Dec 14, 2022
@mastercoms
Copy link
Member

Are you using status branches? If so, what is your setup for that?

@oivio
Copy link
Author

oivio commented Dec 14, 2022

Are you using status branches? If so, what is your setup for that?

I am really sorry, possibly it was my mistake. Didn't use source control instead I did a zip file from the site and tried to run it.
So this time I did clone the repo and use the files from it. So far no crashes ;)

Will definitely shout if this will happen again.

@oivio oivio closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants