Misc improvements #110
Misc improvements #110
Conversation
jeffason
commented
Jun 8, 2023
jeffason
commented
- Support status branch patterns (e.g. "release/*")
- Force restart the editor when Plugins/ binary changes detected
- Bugfix: read-only file attribute gets out of sync with LFS lock status
…dingRestart editor checks
| Parameters.Add(TEXT("--list")); | ||
| bool bResults = RunCommand(TEXT("branch"), InPathToGitBinary, InRepositoryRoot, Parameters, { PatternMatch }, | ||
| InfoMessages, ErrorMessages); | ||
| if (bResults && InfoMessages.Num() > 0) |
There was a problem hiding this comment.
when using origin/* this includes origin/HEAD -> origin/main right? Does this break the feature, or does it not matter?
There was a problem hiding this comment.
Not at a computer but why would ‘git branch —list’ return origin/HEAD which is not a branch?
There was a problem hiding this comment.
Why, I don't know. but in all my git(lab) projects it does:
C:\Users\...>git branch --remote --list origin/*
origin/HEAD -> origin/main
origin/main
There was a problem hiding this comment.
Did you confirm this is broken by setting a breakpoint in the debugger?
It seems atypical to define origin/* as a status branch pattern but if it breaks then we should handle it elegantly.
These branch patterns were added to support common, standardized branching patterns in git like gitflow - https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow
There was a problem hiding this comment.
See screenshot, confirmed that it adds it to the results
There was a problem hiding this comment.
Good find. Try git branch --format='%(refname:short)'
