Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule support #75

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

Louspirit
Copy link

@Louspirit Louspirit commented Jan 17, 2023

Adding support to do all git operations for GIT Submodules that would be located in the Plugins folder.
The use case is sharable content plugins you would maintain outside the project repository.

See SRombauts/UEGitPlugin#44

@mastercoms
Copy link
Member

Thanks for this! Looks feasible on first glance, will review it hopefully later in this week!

@Louspirit Louspirit force-pushed the submodule-support branch 2 times, most recently from 33d6f84 to f1d4072 Compare January 17, 2023 21:53
@Louspirit
Copy link
Author

I fixed a compilation error. Made a push force using a rebase interactive to keep one commit.
It should be ready to merge now.

@mastercoms
Copy link
Member

mastercoms commented Jan 28, 2023

Hi sorry, will have to do this in February, got swamped with a lot of unexpected work

@Louspirit
Copy link
Author

Hello, just coming for news 😁

@mastercoms
Copy link
Member

Hi, I've been getting really behind D: I'm really trying to catch up on my Unreal Engine work but I will have reduced time until maybe May or June

@ameaninglessname
Copy link
Contributor

Hello, just coming for news 😁

image
Just rebased your changes to latest locally, it works on sub-modules, and blueprint diif.
(though I didn't think I changed any of these "PropertyAccess" things, it should be the mistake of blueprint diff tool)

@ameaninglessname
Copy link
Contributor

image

@Louspirit
Copy link
Author

As suggested by @ameaninglessname, I did a rebase with the latest stuff, removing conflicts. You can do the merge when you're ready @mastercoms

@mastercoms mastercoms merged commit 3301508 into ProjectBorealis:release Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants