add additional whitelisting in .gitignore #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i am proposing this change to assist the installation process in project scope. especially when user trying to add ue git plugin inside the project to ease distribution. since recommended `.gitignore` of pbcore ignores git-lfs.exe files which required by the plugin to works
mastercoms
requested changes
Jan 21, 2023
|
the other executable doesn't get ignored by pbcore .gitignore by default. or you'd say just add it to gitignore whitelist regardless the condition ?
|
|
Some people use the Epic gitignore which ignores everything by default, so it's good to include it |
Add additional .gitignore white listing for executable required by the plugin to works
|
updated with all executables files |
mastercoms
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i am proposing this change to assist the installation process in project scope.
especially when user trying to add ue git plugin inside the project to ease distribution. since recommended
.gitignoreof pbcore ignores git-lfs.exe files which required by the plugin to works