Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up warnings #181

Merged
merged 2 commits into from
May 17, 2019
Merged

Cleans up warnings #181

merged 2 commits into from
May 17, 2019

Conversation

intere
Copy link
Collaborator

@intere intere commented May 17, 2019 •
edited
Loading

Background

  • Cleans up the compiler warnings (with one exception) in the library and the example project. The remaining warning is that we don't have a 1024x1024 app icon. ¯\_(ツ)_/¯
  • cleans up swiftlint warnings (v 0.27.0)

Breaking Changes

N/A

Meta

  • Tied to Version Release(s): next (post 1.1.0)

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • N/A Tests have have been added to all new features. (not a requirement, but helpful)
  • N/A Image/GIFs have been added for all UI related changed.

@intere
Cleans up the warnings (with one exception) in the library and the ex…
7d68920 
…ample project. The remaining warning is that we don't have a 1024x1024 app icon. ¯\_(ツ)_/¯
@intere intere self-assigned this May 17, 2019
@intere intere mentioned this pull request May 17, 2019
Closed
5 tasks
@intere intere requested a review from aaronbrethorst May 17, 2019 20:54
@intere intere marked this pull request as ready for review May 17, 2019 20:54
aaronbrethorst
aaronbrethorst approved these changes May 17, 2019
View reviewed changes
Copy link
Collaborator

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👍

@aaronbrethorst aaronbrethorst merged commit 6496f4d into AndrewHartAR:develop May 17, 2019
@intere intere deleted the enhancement/cleanup-warnings branch May 17, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees

@intere intere

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intere @aaronbrethorst