Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default lighting #224

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Conversation

Pilot-Marc
Copy link
Collaborator

Background

Enable Default Lighting

Breaking Changes

N/A

Meta

  • Tied to Version Release(s):

PR Checklist

  • CI runs clean?
  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

@@ -213,6 +213,11 @@ extension POIViewController {
sceneLocationView.addLocationNodeWithConfirmedLocation(locationNode: $0)
}
}

// There are many differnet ways to add lighting to a scene, but even this mechanism (the absolute simplest)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/differnet/different/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@intere intere merged commit a9e9a5b into AndrewHartAR:develop Oct 10, 2019
@Pilot-Marc Pilot-Marc deleted the default-lighting branch November 19, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants