Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL (Apollo) data as its own package #278

Closed
1 of 5 tasks
thescientist13 opened this issue Jan 17, 2020 · 2 comments · Fixed by #487 or #490
Closed
1 of 5 tasks

GraphQL (Apollo) data as its own package #278

thescientist13 opened this issue Jan 17, 2020 · 2 comments · Fixed by #487 or #490
Assignees
Labels
alpha.8 CLI Content as Data P0 Critical issue that should get addressed ASAP v0.10.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jan 17, 2020

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Should @greenwood/cli/data, e,g. package/cli/data be it's own distinct package?

Details

There's also the case that it can be its own package (to maintain its own test cases, dependencies, etc) but have it be a direct dependency of @greenwood/cli. Essentially they would be functionally coupled, but benefit by having code logically organized.

Also, for now, we can just alias it as @greenwood/data and that way, if it becomes a package or not, it won't break user land code since the import path will stay the same.

@thescientist13 thescientist13 added question Further information is requested Content as Data labels Jan 17, 2020
@thescientist13 thescientist13 added this to the MVP milestone Jan 17, 2020
@thescientist13 thescientist13 changed the title should data be its own package? should data be its own package / navigation? Jan 24, 2020
@thescientist13 thescientist13 mentioned this issue Jan 29, 2020
13 tasks
@thescientist13
Copy link
Member Author

I think coming out of #355 this will happen organically.

@thescientist13 thescientist13 changed the title should data be its own package / navigation? data should be its own package (?) Nov 7, 2020
@thescientist13
Copy link
Member Author

Re-purposing to help solve #418

  1. Make data a plugin and something lighter than apollo?
  2. update all usages to use @data/client instead of fetch in www/
  3. See if data hydration still an issue
  4. reduce duplicate graphql calls?

@thescientist13 thescientist13 changed the title data should be its own package (?) GraphQL (Apollo) data should be its own package (?) Nov 8, 2020
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Nov 8, 2020
@thescientist13 thescientist13 removed the question Further information is requested label Nov 8, 2020
@thescientist13 thescientist13 changed the title GraphQL (Apollo) data should be its own package (?) GraphQL (Apollo) data as its own package Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment