Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 1313 set shamefully-hoist pnpm flag in .npmrc for init scaffolding #1314

Merged
merged 1 commit into from
Nov 14, 2024
Merged

enhancement/issue 1313 set shamefully-hoist pnpm flag in .npmrc for init scaffolding #1314

merged 1 commit into from
Nov 14, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 13, 2024 •
edited
Loading

Related Issue

#1313

Documentation

Already documented for the init step at least - https://greenwoodjs.dev/docs/introduction/setup/#install

Summary of Changes

  1. For now, this will at least ensure new project scaffolding interops reasonably well with pnpm even if it "ejects" out of pnpm's ideal setup (longer term solution will come later)

@thescientist13 thescientist13 added this to the 1.0 milestone Nov 13, 2024
@thescientist13 thescientist13 changed the title feature/issue 1313 set shamefully-hoist flag in .npmrc for init scaffolding feature/issue 1313 set shamefully-hoist pnpm flag in .npmrc for init scaffolding Nov 13, 2024
@thescientist13 thescientist13 changed the title feature/issue 1313 set shamefully-hoist pnpm flag in .npmrc for init scaffolding enhancement/issue 1313 set shamefully-hoist pnpm flag in .npmrc for init scaffolding Nov 14, 2024
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Nov 14, 2024
@thescientist13 thescientist13 merged commit 13ab563 into master Nov 14, 2024
8 checks passed
@thescientist13 thescientist13 deleted the feature/issue-1313-shamefully-hoist-init-package-npmrc branch November 14, 2024 00:33
@thescientist13 thescientist13 linked an issue Nov 14, 2024 that may be closed by this pull request
PNPM support (not hardcoding location of node_modules on disk) #1313
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) Init v0.30.2
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: ✅ Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

PNPM support (not hardcoding location of node_modules on disk)
1 participant
@thescientist13