Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hashing and marker detection and make specs more explicit #573

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 25, 2021

Related Issue

resolves #572

Summary of Changes

Ooof, a couple things going on here that we not properly implemented (my bad)

  1. Hashing was not implemented correctly and not really generating unique IDs, so copied over hashing function from graphql (for now)
  2. Fixed marker detection logic

TODOs

  1. Check for other inline cases of plain <script> and <style>, add specs as needed
  2. eve-container module not being bundled now
  3. Should make an issue to make sure <style>/* code */ and <script>/* code */</style> are getting optimized / minified - ensure inline <script> and <style> tags are getting minified / optimized when running build command #581
  4. I think this might be the root cause of [demo / bug] inline optimization is broken on subsequent page load #495, should see if it helps after this is merged

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels Apr 25, 2021
@thescientist13 thescientist13 marked this pull request as ready for review April 25, 2021 17:12
@thescientist13

This comment has been minimized.

@thescientist13 thescientist13 removed their assignment Apr 29, 2021
@thescientist13 thescientist13 merged commit 1db5685 into master Apr 29, 2021
@thescientist13 thescientist13 deleted the bug/issue-572-fix-rollup-inline-optimizing-markers branch April 29, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple inline <script> tags not getting correctly optimized - all tags show the same contents
1 participant