Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/leading slash in CSS (<link>) paths break bundling #981

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Bug/leading slash in CSS (<link>) paths break bundling #981

merged 3 commits into from
Oct 15, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 1, 2022 •
edited
Loading

Related Issue

#971

Found that CSS paths with a leading / in their path was throwing a 404 with production bundling

<link rel="stylesheet" href="/styles/theme.css"></link>

Screen Shot 2022-10-01 at 2 09 39 PM

Summary of Changes

  1. Normalize creating optimizedFileName for CSS (<link>) assets

TODO

  1. Should make sure this is covered by a test case somewhere (and remove console.log)

@thescientist13 thescientist13 added bug Something isn't working alpha.1 v0.27.0 labels Oct 1, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Oct 1, 2022
@thescientist13 thescientist13 self-assigned this Oct 1, 2022
@thescientist13 thescientist13 mentioned this pull request Oct 1, 2022
Merged
1 task
@thescientist13 thescientist13 added CLI P0 Critical issue that should get addressed ASAP labels Oct 1, 2022
This was referenced Oct 1, 2022
Merged
Merged
@thescientist13 thescientist13 merged commit 2088e84 into release/0.27.0 Oct 15, 2022
@thescientist13 thescientist13 deleted the bug/leading-slash-css-path-breaks-bundling branch October 15, 2022 16:15
thescientist13 added a commit that referenced this pull request Nov 3, 2022
@thescientist13
Bug/leading slash in CSS (<link>) paths break bundling (#981)
593c964 
* normalize leading / for CSS bundling paths

* update test cases

* remove console logs
thescientist13 added a commit that referenced this pull request Nov 12, 2022
@thescientist13
Bug/leading slash in CSS (<link>) paths break bundling (#981)
6398b48 
* normalize leading / for CSS bundling paths

* update test cases

* remove console logs
thescientist13 added a commit that referenced this pull request Nov 23, 2022
@thescientist13
Bug/leading slash in CSS (<link>) paths break bundling (#981)
d1bf051 
* normalize leading / for CSS bundling paths

* update test cases

* remove console logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
alpha.1 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.27.0
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13