Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and cleanup the Xyz procedure #1130

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Update and cleanup the Xyz procedure #1130

wants to merge 29 commits into from

Commits on May 19, 2024

  1. Replace magic effect values in xyz proc with constants

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e665494 View commit details
    Browse the repository at this point in the history

  2. Xyz proc: remove usage of 946 token 

    It was used when the xyz had an extra filter function on its materials while parsing EFFECT_SPELL_XYZ_MAT, being it a random generic token with properties this check is redoundant and most of the times it won't work, as if a card has a filter then it requires specific properties from the monster, now EFFECT_SPELL_XYZ_MAT will only be applied if the xyz has no filter function
    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    be1acf3 View commit details
    Browse the repository at this point in the history

  3. Xyz proc: add Xyz.GetMaterials to clean up the logic a bit

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ca0c7d4 View commit details
    Browse the repository at this point in the history

  4. Xyz proc: update logic in Xyz.RecursionChk 

    Remove repeated checks for GetCardEffect, also properly short circuit the recursive function if a valid material set is found
    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    61cf909 View commit details
    Browse the repository at this point in the history

  5. Xyz proc: other updates to Xyz.RecursionChk 

    Add more early returns and avoid extra recursions
    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3cc008f View commit details
    Browse the repository at this point in the history

  6. Xyz proc: Remove the separate logics for material selection 

    Use the same function to check for a valid summonable xyz
    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e45c82b View commit details
    Browse the repository at this point in the history

  7. Xyz proc: update alternate xyz summon

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ce8683d View commit details
    Browse the repository at this point in the history

  8. Xyz proc: add Xyz.InfiniteMats to represent n+ materials

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c47cb02 View commit details
    Browse the repository at this point in the history

  9. Xyz poc: Set Xyz.InfiniteMats sentinel value to 99

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c112c01 View commit details
    Browse the repository at this point in the history

  10. Xyz proc: Fixup anime effects interactions

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3b23a6d View commit details
    Browse the repository at this point in the history

  11. Xyz proc: update automatic material selection logic 

    If a must material group is passed to the xyz proc, and the min and max values match the size of that group, then if those materials are valid within the material group, the selection will be skipped
    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a1712b0 View commit details
    Browse the repository at this point in the history

  12. Update cards using Duel.XyzSummon

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f6678fb View commit details
    Browse the repository at this point in the history

  13. Halfway to Forever

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9a67375 View commit details
    Browse the repository at this point in the history

  14. Gazer Shark

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9ff2552 View commit details
    Browse the repository at this point in the history

  15. Galaxy Tyranno

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f9219cb View commit details
    Browse the repository at this point in the history

  16. Geargia Change

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8d3508c View commit details
    Browse the repository at this point in the history

  17. Artifacts Unleashed

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    143ba06 View commit details
    Browse the repository at this point in the history

  18. Advanced Heraldry Art

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6dc279d View commit details
    Browse the repository at this point in the history

  19. Shining Hope Road

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5d1c2da View commit details
    Browse the repository at this point in the history

  20. Destiny overlay

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f637ae8 View commit details
    Browse the repository at this point in the history

  21. Dimension Xyz

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    47abb5c View commit details
    Browse the repository at this point in the history

  22. The Phantom Knights' Twin Medals

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a31b11d View commit details
    Browse the repository at this point in the history

  23. D/D/D Xyz

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    73ae12f View commit details
    Browse the repository at this point in the history

  24. Salamangreat Zebroid X (Anime)

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0b79350 View commit details
    Browse the repository at this point in the history

  25. Use Xyz.InfiniteMats constant

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8689419 View commit details
    Browse the repository at this point in the history

  26. Reorder functions

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1da3c90 View commit details
    Browse the repository at this point in the history

  27. Reapply 27b135c

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    acfcbae View commit details
    Browse the repository at this point in the history

  28. Add count limit support to EFFECT_DOUBLE_XYZ_MATERIAL

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0aa47ba View commit details
    Browse the repository at this point in the history

  29. Fix wrong variable name

    @edo9300
    edo9300 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    99ef400 View commit details
    Browse the repository at this point in the history