Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Content Publishing Service should write bytes not ascii bytes to the content hash field of the parquet file #340

Closed
3 tasks done
wilwade opened this issue Aug 5, 2024 · 0 comments · Fixed by #343

Comments

@wilwade
Copy link
Contributor

wilwade commented Aug 5, 2024

Per the dsnp spec, write the bytes of the hash not the ascii bytes of the hash to the content hash column of the batch files.

  • Fixed in Content Publishing
  • Checked that it is correctly read in Content Watcher and correctly re-encoded in responses
  • Checked in SAT to make sure it is also handling it correctly

https://spec.dsnp.org/DSNP/Identifiers.html#dsnp-content-hash

pqrs head bafybeids3isqheoovbyeoivh33e2xhi7bibvzvsek7e3wgeulvdtv44gmm.txt

{announcementType: 2, contentHash: [122, 56, 122, 102, 102, 84, 66, 107, 54, 114, 97, 89, 88, 49, 49, 72, 84, 114, 98, 118, 87, 104, 72, 80, 121, 55, 87, 114, 104, 52, 88, 97, 118, 89, 121, 49, 69, 116, 75, 50, 103, 104, 102, 50, 87, 120, 88, 75, 55, 69, 103, 107, 78, 84, 54, 80], fromId: 6400, url: "https://gateway-testnet.infura-ipfs.io/ipfs/bafybeihesqau7avquwmzvaguwsafhlixcuwbhul7yy4pnztpb3dkca3dna"}

image
via https://www.rapidtables.com/convert/number/ascii-hex-bin-dec-converter.html

bafybeids3isqheoovbyeoivh33e2xhi7bibvzvsek7e3wgeulvdtv44gmm.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants