Bug 340: Content hash is out of spec in announcements #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraswatpuneet
changed the title
saraswatpuneet
commented
Aug 6, 2024
saraswatpuneet
commented
Aug 6, 2024
services/content-publishing/libs/common/src/utils/ipfs.client.ts
Outdated
Show resolved
Hide resolved
saraswatpuneet
commented
Aug 6, 2024
services/content-publishing/apps/worker/src/request_processor/dsnp.announcement.processor.ts
Show resolved
Hide resolved
saraswatpuneet
changed the title
saraswatpuneet
commented
Aug 6, 2024
| const mb = await service.ipfsHashBuffer(Buffer.from("abc")); | ||
| expect(mb).toMatch("z2DrjgbH33g3bTa7dPaMq1XbVmKH11m2SwxAF6aNzSd5F3j63p4"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
picked up an old test https://github.com/LibertyDSNP/activity-content/blob/main/src/test/hash.test.ts
saraswatpuneet
commented
Aug 6, 2024
saraswatpuneet
changed the title
JoeCap08055
reviewed
Aug 7, 2024
services/content-publishing/libs/common/src/utils/ipfs.client.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Caputo <joseph.caputo@amplica.io>
saraswatpuneet
commented
Aug 7, 2024
| const hash = create(hasher.code, hashed.bytes); | ||
| return base58btc.encode(hash.bytes); | ||
| const hash = await sha256.digest(fileBuffer); | ||
| return base32.encode(hash.bytes); |
There was a problem hiding this comment.
according to dsnp spec (to be updated) base32(multihash)
wilwade
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Content watcher bug #340 in calculating
contentHash,Details
Closes: #340
Solution
What I/we did to solve this problem
Fixed by following DSNP spec and hashing the bytes of content in line with DSNP