account-service should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to `webhookBaseUrl`
4 tasks
mattheworris
commented
Aug 8, 2024
mattheworris
commented
Aug 8, 2024
mattheworris
commented
Aug 8, 2024
mattheworris
commented
Aug 8, 2024
mattheworris
commented
Aug 8, 2024
|
|
||
| # Remove specified volumes | ||
| echo "Removing specified volumes..." | ||
| docker volume rm account-service_redis_data | ||
| docker volume rm account-service_chainstorage | ||
| docker volume rm gateway_redis_data |
There was a problem hiding this comment.
docker-compose.yaml file moved to root, so targets needed to be renamed to match.
wilwade
reviewed
Aug 8, 2024
…-microservices-that-use-a-webhook-should-replace-provider_base_url-with-webhook_base_url
4 tasks
…f `PROVIDER_BASE_URL`
mattheworris
changed the title
mattheworris
requested review from
claireolmstead,
JoeCap08055 and
saraswatpuneet
JoeCap08055
reviewed
Aug 9, 2024
JoeCap08055
approved these changes
Aug 9, 2024
mattheworris
deleted the
218-microservices-that-use-a-webhook-should-replace-provider_base_url-with-webhook_base_url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gateway microservices that use webhooks previously used the environment variable
PROVIDER_BASE_URLas the webhook target server. Thesocial-app-templatehas adopted a new nomenclature usingWEBHOOK_BASE_URL. All micro services should be in sync with thesocial-app-templateand use the new nomenclature.Acceptance Criteria
WEBHOOK_BASE_URLto provision their webhook.Follow up to remove entirely: #339