Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update start and stop scripts for Gateway services #380

Merged
merged 7 commits into from
Aug 14, 2024

Conversation

mattheworris
Copy link
Contributor

While writing the documentation, there are some minor fixes. Here's the tracking list of them

  • Should be be start-gateway.sh or just start.sh
  • We should remove the default Provider Id from the setup script
  • Update "DEFAULT seed phrase needed" -> "Required for Testnet"
  • Remove script option for "Enter the location of the Content DB"

Closes #201

@mattheworris mattheworris linked an issue Aug 13, 2024 that may be closed by this pull request
4 tasks
@mattheworris mattheworris self-assigned this Aug 13, 2024
@@ -22,7 +22,8 @@ if [ -f .env-saved ]; then
echo -e "Found saved environment from a previous run:\n"
cat .env-saved
echo
read -p "Do you want to re-use the saved paramters? [y/N]: " REUSE_SAVED
read -p "Do you want to re-use the saved paramters? [Y/n]: " REUSE_SAVED
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to match SAT

@@ -116,11 +116,12 @@ EOI
cat << EOI

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ IPFS settings ┃
┃ Do you want to change the IPFS settings [y/N]: ┃
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to match SAT

@@ -148,14 +150,6 @@ then
# Start specific services in detached mode
echo -e "\nStarting local frequency services..."
docker compose up -d frequency

# Wait for 15 seconds
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary for gateway now.

start.sh Outdated Show resolved Hide resolved
@claireolmstead
Copy link
Contributor

claireolmstead commented Aug 14, 2024

Only question here... if we're pointing out that the seed phrase is required for testnet, we should probably point out that the provider id and some of the IPFS things are also required.

Additional solution: Change the IPFS default values based on if they select local or testnet?

@mattheworris
Copy link
Contributor Author

Only question here... if we're pointing out that the seed phrase is required for testnet, we should probably point out that the provider id and some of the IPFS things are also required.

Additional solution: Change the IPFS default values based on if they select local or testnet?

PROVIDER_ID default is also "INPUT REQUIRED"

The IPFS defaults have been updated so that they should work with local and testnet.
(tracking an issue on SAT where IPFS links are not using the IPFS UA gateway to resolve, but I think all the gateway services are happy with these defaults)

@mattheworris mattheworris merged commit 36b5e47 into main Aug 14, 2024
7 of 11 checks passed
@mattheworris mattheworris deleted the 201-misc-fixes-from-documentation branch August 14, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc Fixes from Documentation
4 participants