-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update start and stop scripts for Gateway services #380
Conversation
@@ -22,7 +22,8 @@ if [ -f .env-saved ]; then | |||
echo -e "Found saved environment from a previous run:\n" | |||
cat .env-saved | |||
echo | |||
read -p "Do you want to re-use the saved paramters? [y/N]: " REUSE_SAVED | |||
read -p "Do you want to re-use the saved paramters? [Y/n]: " REUSE_SAVED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to match SAT
@@ -116,11 +116,12 @@ EOI | |||
cat << EOI | |||
|
|||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓ | |||
┃ IPFS settings ┃ | |||
┃ Do you want to change the IPFS settings [y/N]: ┃ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to match SAT
@@ -148,14 +150,6 @@ then | |||
# Start specific services in detached mode | |||
echo -e "\nStarting local frequency services..." | |||
docker compose up -d frequency | |||
|
|||
# Wait for 15 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary for gateway now.
Only question here... if we're pointing out that the seed phrase is required for testnet, we should probably point out that the provider id and some of the IPFS things are also required. Additional solution: Change the IPFS default values based on if they select local or testnet? |
…-misc-fixes-from-documentation
The IPFS defaults have been updated so that they should work with local and testnet. |
While writing the documentation, there are some minor fixes. Here's the tracking list of them
start-gateway.sh
or juststart.sh
Closes #201