Improve CI #387
Merged
Improve CI #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To Revert If statements for skipping when not needed Getting the matrix working... maybe Matrix doesn't work in job level if statements Applying the if statement to every step Caching docker layers Trigger the build of the api specs as part of the build test Try switching registries Cleanup
wilwade
commented
Aug 14, 2024
| @@ -9,71 +9,125 @@ on: | |||
| - main | |||
|
|
|||
| jobs: | |||
| determine-service-matrix: | |||
| service-matrix: | |||
There was a problem hiding this comment.
Rename so the lines don't get so long below
wilwade
commented
Aug 14, 2024
| changes: ${{ steps.determine-matrix.outputs.changes }} | ||
| # IF you add a new filter it ALSO needs to be here | ||
| services: >- | ||
| ["account", "graph", "content-publishing", "content-watcher"] |
There was a problem hiding this comment.
I tried to find a way not to have to do this, but no luck. This was still the best way.
wilwade
commented
Aug 14, 2024
| working-directory: services/${{ matrix.service }} | ||
| # List all the licenses and error out if it is not one of the supported licenses | ||
| run: npx license-report --fields=name --fields=licenseType | jq 'map(select(.licenseType | IN("MIT", "Apache-2.0", "ISC", "BSD-3-Clause", "BSD-2-Clause", "(Apache-2.0 AND MIT)", "Apache-2.0 OR MIT") | not)) | if length == 0 then halt else halt_error(1) end' | ||
|
|
||
| - name: Build OpenAPI spec |
There was a problem hiding this comment.
Part of the release that broke on v1.0, so this is to keep it from breaking.
wilwade
commented
Aug 14, 2024
.github/workflows/build.yml
Outdated
| with: | ||
| config-inline: | | ||
| [registry."ghcr.io"] | ||
| - name: Cache Docker layers |
There was a problem hiding this comment.
Not really sure this is worth doing, but I did it.
wilwade
commented
Aug 14, 2024
| @@ -9,84 +9,103 @@ on: | |||
| - main | |||
|
|
|||
| jobs: | |||
| determine-service-matrix: | |||
| service-matrix: | |||
There was a problem hiding this comment.
This is the same set of changes as build.yml limited to the matrix changes and no additional jobs
wilwade
commented
Aug 14, 2024
| echo "SERVICE=${SERVICE}" >> $GITHUB_OUTPUT | ||
| echo "SERVICE_MATRIX=${SERVICE_MATRIX}" >> $GITHUB_OUTPUT | ||
| echo "valid=${valid}" >> $GITHUB_OUTPUT | ||
| echo "test_run=${test_run}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Update to the new version of this
wilwade
commented
Aug 14, 2024
wilwade
commented
Aug 14, 2024
| @@ -15,7 +15,7 @@ process.env.PROVIDER_ACCOUNT_SEED_PHRASE = | |||
| 'offer debate skin describe light badge fish turtle actual inject struggle border'; | |||
| process.env.PROVIDER_ID = '0'; | |||
| process.env.WEBHOOK_BASE_URL = 'http://127.0.0.1'; | |||
| process.env.CAPACITY_LIMIT = '{"type":"amount","value":"1"}'; | |||
| process.env.CAPACITY_LIMIT = '{"type":"amount","value":"80"}'; | |||
There was a problem hiding this comment.
These are updates to fix the broken swagger builds
mattheworris
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems Fixed