feat: at startup, check to make sure provider seed phrase matches configured provider ID #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figured provider ID
wilwade
reviewed
Aug 26, 2024
|
|
||
| public async validateProviderSeedPhrase() { | ||
| const { providerPublicKeyAddress, providerId } = this.configService; | ||
| const resolvedProviderId = await this.publicKeyToMsaId(providerPublicKeyAddress || ''); |
There was a problem hiding this comment.
Does this not error out with the '' version?
There was a problem hiding this comment.
Good point--not sure what the chain state query does if you pass an empty string for the public key. Reworked to skip querying the chain entirely if there's no public key (ie, no seed phrase configured).
This behavior is intended for the upcoming "read-only" mode. Note that currently you MUST configure a seed phrase because it's required in the environment config; once that requirement is relaxed, this behavior will take effect.
wilwade
approved these changes
Aug 26, 2024
JoeCap08055
deleted the
419-services-should-validate-provider-seed-phrase-at-startup
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
account,content-publishing,content-watcherto query the chain for the MSA ID associated with the public key derived from the configured seed phrase; throw an error if it does not match the configured Provider IDBlockchainServiceingraph-servicewith the rest of the services' implementations (missed in previous PR)Closes #419