-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
413 changehandle #458
Merged
Merged
413 changehandle #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
claireolmstead
commented
Aug 29, 2024
claireolmstead
requested review from
mattheworris,
shannonwells,
wilwade and
enddynayn
August 29, 2024 17:26
JoeCap08055
reviewed
Aug 29, 2024
services/account/apps/api/src/controllers/v1/handles-v1.controller.ts
Outdated
Show resolved
Hide resolved
JoeCap08055
reviewed
Aug 29, 2024
JoeCap08055
reviewed
Aug 29, 2024
services/account/apps/api/src/controllers/v1/handles-v1.controller.ts
Outdated
Show resolved
Hide resolved
JoeCap08055
requested changes
Aug 29, 2024
services/account/apps/api/src/controllers/v1/handles-v1.controller.ts
Outdated
Show resolved
Hide resolved
services/account/apps/api/src/controllers/v1/handles-v1.controller.ts
Outdated
Show resolved
Hide resolved
JoeCap08055
approved these changes
Aug 30, 2024
claireolmstead
force-pushed
the
413-changehandle
branch
from
August 30, 2024 19:04
aca1d7d
to
f10b7a7
Compare
mattheworris
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through changes
- Requesting updates to block expiration
mattheworris
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We do not have an endpoint to return an encoded payload for signing a change handle call.
Link to GitHub Issue(s): #413
Solution
with @JoeCap08055 @enddynayn
Steps to Verify: