Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to full monorepo setup #459

Merged
merged 24 commits into from
Sep 6, 2024
Merged

Convert to full monorepo setup #459

merged 24 commits into from
Sep 6, 2024

Conversation

JoeCap08055
Copy link
Contributor

@JoeCap08055 JoeCap08055 commented Aug 29, 2024 •
edited
Loading

This PR reconfigures the repo as a true monorepo, instead of a repo of [essentially] sub-repos (which was how it began life). It uses the NestJS monorepo configuration. All apps are first-class citizens under apps/ and all original libraries for each service are under libs/<service-name>-lib. The imports have all been adjusted to compile & run with sources in the new locations.

Also included in this PR:

  • Port & unify individual service npm scripts
  • Update CI pipeline for new structure
  • Update top-level Makefile

No code refactoring is part of this PR; that will come after this is merged.

@JoeCap08055 JoeCap08055 linked an issue Aug 29, 2024 that may be closed by this pull request
Convert repo structure to use actual monorepo tooling #449
Closed
3 tasks
@JoeCap08055 JoeCap08055 marked this pull request as ready for review September 4, 2024 20:46
@JoeCap08055
Copy link
Contributor Author

Looks like all CI is green (the pending ones I believe are artifacts from main that will go away once this branch is merged).
We won't be able to test the release pipeline until this is merged, but Docker image builds have been tested locally.

wilwade
wilwade reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but in general looks good.

  • Reviewed all changes
  • Did NOT run locally

.github/workflows/load-tests.yml Show resolved Hide resolved
apps/account-api/src/controllers/v1/accounts-v1.controller.ts Outdated Show resolved Hide resolved
docker-compose-k6.account-api.yaml Show resolved Hide resolved
libs/content-watcher-lib/src/crawler/crawler.service.ts Show resolved Hide resolved
openapi-specs/account.openapi.json Outdated Show resolved Hide resolved
apps/account-api/src/controllers/v1/handles-v1.controller.ts Show resolved Hide resolved
Docker/Dockerfile.content-watcher Show resolved Hide resolved
@enddynayn
Copy link
Contributor

enddynayn commented Sep 5, 2024 •
edited
Loading

Are we certain we want to move forward with this right now? It doesn’t introduce any new features, and there’s a chance it could lead to disorder or additional bugs and issues. Especially if we put a pause, we might end up leaving things worse off.

@wilwade
Copy link
Contributor

wilwade commented Sep 5, 2024

Are we certain we want to move forward with this right now? It doesn’t introduce any new features, and there’s a chance it could lead to disorder or additional bugs and issues. Especially if we put a pause, we might end up leaving things worse off.

Yes. A lot of the work coming up is hardening, and this reduces the number of updates in multiple places reducing the bug chances for that work.

@enddynayn
Copy link
Contributor

Are we certain we want to move forward with this right now? It doesn’t introduce any new features, and there’s a chance it could lead to disorder or additional bugs and issues. Especially if we put a pause, we might end up leaving things worse off.

Yes. A lot of the work coming up is hardening, and this reduces the number of updates in multiple places reducing the bug chances for that work.

Sounds good. Thanks for answering my question.

@JoeCap08055 @wilwade
Update apps/account-api/src/controllers/v1/accounts-v1.controller.ts
d6a4485 
Co-authored-by: Wil Wade <wil.wade@amplica.io>
mattheworris
mattheworris approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through all files changes
  • Tested containers with SAT 🚀
  • Nice work! Say goodbye to redundant code soon!

🚢 it!

@JoeCap08055
fix: last bits of repo refactoring
7e8a78f 
- make sure all relevant npm scripts are ported to top-level
- reorganize repo docs (not published docs)
- exclude generated files from lint & formatting
- get rid of old 'services' directory
aramikm
aramikm approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Only read the code

Looks good just added some questions.

.github/workflows/build.yml Show resolved Hide resolved
apps/account-api/src/controllers/v1/handles-v1.controller.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@JoeCap08055 JoeCap08055 merged commit 98f1c5e into main Sep 6, 2024
11 checks passed
@JoeCap08055 JoeCap08055 deleted the 449-convert-repo-structure-to-use-actual-monorepo-tooling branch September 6, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilwade wilwade wilwade left review comments

@aramikm aramikm aramikm approved these changes

@mattheworris mattheworris mattheworris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert repo structure to use actual monorepo tooling
5 participants
@JoeCap08055 @enddynayn @wilwade @mattheworris @aramikm