Refactor const, enum, interface & dto definitions to a common component #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramikm
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Great work! I added some questions and nits. a few things
- I wished we've done this service by service so it would be easier to test and evaluate but since this is already done doesn't make sense to split the PRs. I think going forward it might make sense to do these service by service.
- I think renaming
AnnouncementTypeDtotoAnnouncementTypeNamewhile is nice, it made this PR bigger than it already is and increased the risk on breaking functionality.
aramikm
approved these changes
Sep 11, 2024
JoeCap08055
force-pushed
the
chore/refactor-const-enums-interfaces-to-common-component
branch
from
01b096f
to
61a1ef6
Compare
aramikm
reviewed
Sep 12, 2024
JoeCap08055
commented
Sep 12, 2024
JoeCap08055
force-pushed
the
chore/refactor-const-enums-interfaces-to-common-component
branch
from
bc1b86e
to
903f438
Compare
JoeCap08055
deleted the
chore/refactor-const-enums-interfaces-to-common-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #450
Note, this is probably the largest of a number of planned refactoring PRs, due to the large number of files being moved. Future PRs will focus on a single module/service to refactor, and so should have a smaller impact in number of files.