-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph-api: added more validation #515
Conversation
15aee0e
to
dea91ab
Compare
@@ -15,7 +16,7 @@ export class WatchGraphsDto { | |||
|
|||
@IsNotEmpty() | |||
@IsString() | |||
@IsUrl({ require_tld: false }) | |||
@IsUrl({ require_tld: false, require_protocol: true, require_valid_protocol: true }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good to know 💡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through the code
- Looks good, agree with other comments
🚢 it
3e5997c
to
e9a0631
Compare
85fc81d
to
7617c54
Compare
Regarding e2e tests: if we have a working e2e test framework, then it's worth while to add tests, because the test scenarios themselves for endpoint validation won't change--only the test framework setup will change, and we'll add additional tests for worker scenarios. But if you want to add tests in a separate PR, that's fine. |
I think it would makes sense to add those tests when the framework is ready simply due to improved velocity of writing and verifying them compared to current state that if something goes wrong I would have to dig to see if my written test is the issue or the framework setup. |
Problem
Adds extra validation on graph-api dtos and request/path params
Closes #496
Discussion
Steps to Verify: