Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-publisher api: more validations #518

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Content-publisher api: more validations #518

merged 2 commits into from
Sep 24, 2024

Conversation

aramikm
Copy link
Contributor

@aramikm aramikm commented Sep 17, 2024 •
edited
Loading

Problem

Closes #494

Solution

  • moved existed decorators into utils
  • enabled base32 regex verification for ContentHash
  • Added ApiProperty definitions on existing DTOs;
  • minor bugfixes and refactors

Steps to Verify:

  1. Run the content-publishing-api
  2. Open swagger
  3. Try submitting wrong requests

@aramikm aramikm force-pushed the content-publisher-validation branch 3 times, most recently from 40e0257 to d2bdd20 Compare September 24, 2024 00:27
@aramikm aramikm marked this pull request as ready for review September 24, 2024 00:29
@aramikm aramikm requested a review from JoeCap08055 September 24, 2024 00:29
@aramikm aramikm force-pushed the content-publisher-validation branch from 9959514 to 7d39725 Compare September 24, 2024 18:12
@aramikm aramikm merged commit 78af6f3 into main Sep 24, 2024
13 checks passed
@aramikm aramikm deleted the content-publisher-validation branch September 24, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

content-publishing-api endpoints data syntax verification
2 participants
@aramikm @JoeCap08055