Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

account-api: add extra syntax validation #541

Merged
merged 6 commits into from
Sep 20, 2024
Merged

account-api: add extra syntax validation #541

merged 6 commits into from
Sep 20, 2024

Conversation

aramikm
Copy link
Contributor

@aramikm aramikm commented Sep 19, 2024

Problem

Adding more validation in account-api
Closes #492

Details

  • added customer decorators for MsaId and SchemaId and ...
  • Using these new decorators in Dtos
  • Added more api descriptions

Steps to Verify:

  1. run the account-api
  2. open swagger
  3. try invalid inputs

@aramikm aramikm mentioned this pull request Sep 20, 2024
Closed
@aramikm aramikm marked this pull request as ready for review September 20, 2024 00:20
aramikm
aramikm commented Sep 20, 2024
View reviewed changes
metadata.raw.ts.template Show resolved Hide resolved
apps/account-api/k6-test/README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
JoeCap08055
JoeCap08055 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small nit if you want to commit it, otherwise 🚢 it!

@aramikm aramikm enabled auto-merge (squash) September 20, 2024 23:21
@aramikm aramikm merged commit 61baa84 into main Sep 20, 2024
13 checks passed
@aramikm aramikm deleted the account_api_syntax_validation_1 branch September 20, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@claireolmstead claireolmstead Awaiting requested review from claireolmstead

@mattheworris mattheworris Awaiting requested review from mattheworris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

account-api endpoints data syntax verification
2 participants
@aramikm @JoeCap08055