Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor content-watcher service configs #554

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Refactor content-watcher service configs #554

merged 5 commits into from
Sep 24, 2024

Conversation

JoeCap08055
Copy link
Contributor

@JoeCap08055 JoeCap08055 commented Sep 23, 2024 •
edited
Loading

This PR refactors ConfigModule and ConfigService for content-watcher-service.

  • Eliminate custom config service class and rely simply on built-in NestJS ConfigModule, using namespaced configs for individual modules
  • Move config property configuration into module-specific config, ie 'blockchain', 'cache', 'queue', 'account-api', 'account-worker'. (NOTE, as each module is refactored in the future, these module configs will be merged with the corresponding module configs from the other services, but for now they will still be duplicated across the services)
  • Update & add unit tests to cover new config setup

Closes #547

@JoeCap08055 JoeCap08055 linked an issue Sep 23, 2024 that may be closed by this pull request
Refactor content-watcher-service configs #547
Closed
@JoeCap08055 JoeCap08055 requested a review from aramikm September 23, 2024 21:08
aramikm
aramikm approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

libs/content-watcher-lib/src/pubsub/pubsub.config.ts Show resolved Hide resolved
@JoeCap08055 JoeCap08055 merged commit 8682999 into main Sep 24, 2024
13 checks passed
@JoeCap08055 JoeCap08055 deleted the 547-refactor-content-watcher-service-configs branch September 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramikm aramikm aramikm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor content-watcher-service configs
2 participants
@JoeCap08055 @aramikm