SIWF v2 Process Payloads #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
force-pushed
the
siwf-v2/process-return-526
branch
5 times, most recently
from
37b1d35 to
d99e06c
Compare
wilwade
commented
Oct 10, 2024
wilwade
force-pushed
the
siwf-v2/process-return-526
branch
from
d9aa75e to
f815dd7
Compare
wilwade
commented
Oct 11, 2024
wilwade
commented
Oct 11, 2024
wilwade
commented
Oct 11, 2024
wilwade
commented
Oct 11, 2024
| expect(response.body).toHaveProperty('rawCredentials'); | ||
| }); | ||
|
|
||
| // TODO: Is there a way to mock the fetch in the e2e? |
There was a problem hiding this comment.
Is there a way to do this? I don't think there is which means we would need to setup a mock server.
Worth doing it? I can do it fairly easily as we already have a mock server system and clean response json
There was a problem hiding this comment.
If the merge is not urgent then I feel it will be nice to have your piece of mock server already in place, will come handy as we develop more.
There was a problem hiding this comment.
I'll see what I can do on Monday.
wilwade
commented
Oct 11, 2024
mattheworris
approved these changes
Oct 11, 2024
saraswatpuneet
approved these changes
Oct 11, 2024
That was expected. |
wilwade
added a commit
that referenced
this pull request
Oct 18, 2024
# Problem Missed generating the openapi json for the new siwf v2 endpoint. Missed in #600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to process the SIWF v2 payloads. Authenticate the user, and process chain interactions.
Closes #526
Closes #527
Closes #529
Solution
Processed the data using SIWF v2 library and then built the extrinsics to re-use the same queue as SIWF v1.
Steps to Verify:
docker compose up redisnpm run start:account-api:devnpm run start:account-worker:debugnode tools/siwfv2/example.mjs