Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): update content-watcher docs #644

Merged
merged 1 commit into from
Oct 22, 2024
Merged

chore(docs): update content-watcher docs #644

merged 1 commit into from
Oct 22, 2024

Conversation

enddynayn
Copy link
Contributor

@enddynayn enddynayn commented Oct 22, 2024 •
edited
Loading

Update Content-Watcher-Service Documentation structure
and content.

@enddynayn enddynayn force-pushed the chore/gateway-content-watcher-service-docs-issue-603 branch 3 times, most recently from 8ffc026 to 33cd2c6 Compare October 22, 2024 21:13
@enddynayn enddynayn changed the title Chore/gateway content watcher service docs issue 603 chore(docs): update content-watcher docs Oct 22, 2024
@enddynayn enddynayn marked this pull request as ready for review October 22, 2024 21:14
@enddynayn enddynayn force-pushed the chore/gateway-content-watcher-service-docs-issue-603 branch from 33cd2c6 to 8809bb2 Compare October 22, 2024 21:32
saraswatpuneet
saraswatpuneet approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner 🧹

@enddynayn enddynayn force-pushed the chore/gateway-content-watcher-service-docs-issue-603 branch 2 times, most recently from d413887 to e2ed356 Compare October 22, 2024 21:45
claireolmstead
claireolmstead reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the big thing that this is missing is an explanation as to why we have to watch content, which should be near the top. We have to watch becuase things are happening async due to the nature of the chain and how we're queueing posts and puts on chain. I would like to see a little more of a technical description around that.

@enddynayn enddynayn force-pushed the chore/gateway-content-watcher-service-docs-issue-603 branch from e2ed356 to 8a2834f Compare October 22, 2024 21:51
@enddynayn
Copy link
Contributor Author

I think the big thing that this is missing is an explanation as to why we have to watch content, which should be near the top. We have to watch becuase things are happening async due to the nature of the chain and how we're queueing posts and puts on chain. I would like to see a little more of a technical description around that.

Good point. Thanks! I update the documentation to reflect your suggestion.

claireolmstead
claireolmstead approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

@enddynayn enddynayn force-pushed the chore/gateway-content-watcher-service-docs-issue-603 branch from 8a2834f to e82baea Compare October 22, 2024 22:01
@enddynayn
chore(docs): update content-watcher docs
6a7c362 
Update Content-Watcher-Service Documentation structure
and content.

Update Content-Publisher Docs running test.
@enddynayn enddynayn force-pushed the chore/gateway-content-watcher-service-docs-issue-603 branch from e82baea to 6a7c362 Compare October 22, 2024 22:02
@enddynayn enddynayn merged commit 2ccbae4 into main Oct 22, 2024
15 checks passed
@enddynayn enddynayn deleted the chore/gateway-content-watcher-service-docs-issue-603 branch October 22, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@claireolmstead claireolmstead claireolmstead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enddynayn @claireolmstead @saraswatpuneet