Mirador shows no image after using of the mirador-image-tools

[ChrisBethgster]

For reproducing - use the mirador-image-tools.netlify.app instance.

• open for example the following manifest: https://iiif.europeana.eu/presentation/9200396/BibliographicResource_3000118436165/manifest
• use the image tools
  • click "Show image tools"
  • use "Invert colors" for example --> the image is correct inverted
• enable "Thumbnails" on bottom
• click on a thumbnail (WITHOUT scrolling)
• use the image tools -> it works also
• use the scrollbar for selecting a new thumbnail
• try to use image tools
  • use "Invert colors" for example -> no image is visible in mirador
    
• select an other thumbnail -> also no image is shown

[sete-arch]

Hi,

I encountered the same problem.

• use the image tools
  click "Show image tools"
  use "Invert colors" for example --> the image is correct inverted
• click on the button "next"
• use the image tools -> it works also
• click on the button "next" twice (or more)
• try to use image tools -> doesn't work, no visible image

Is there any progress on this issue ?

Thank you

[camillevilla]

Thank you for posting this issue! We were able to recreate this issue and started investigating at community call on 10/28.

Notes:

• this affects any manifest with multiple canvases

[Aylambo]

Hey there,
Is there any fix for that issue?
I'm encountering similar situations to the ones described above.
Thanks :)

[Marcel-Tronco]

Hi, the problem is still there.
For any developers interested in this, my browser console indicated that this is because of a rotation value turning NaN.

Unsupported rotation: NaN [index.html:13441:25]<...> index.html)
    overrideMethod <...>/index.html:13441
    onUpdateViewport <...>/main.js:85
    getHandler <...>/2.main.js:6
    raiseEvent <...>/2.main.js:6
    (Async: FrameRequestCallback)
/*...*/

Best

[Marcel-Tronco]

I fiddled around with this a while longer and tried to reproduce the bug in mirador dev setup to look at it a little closer, i.e. having setup of the mirador repo developing it with webpack serve (using the start scripts) and using the plugin as a preconfigured one there. In this setup the problem does not arise.

I don't know what this means exactly, but made me think of some build/dependency issues as the source of the bug.

Best

[Marcel-Tronco]

I had some time again to look into it. Concerning the last comment testing a little bit longer showed, problems in the other setup are the same.

Yet with the help of react dev tools in the browser I saw that the viewerConfig seems to be (part) of the problem.

Leafing through a manifest in the viewer there are several points, when after changing the page the viewerConfig Prop of the OSD-viewer element and the image tools element becomes null. Now if we continue leafing without changing settings in the image tools for the next page this might reset to the old config we saw a page before eventually and never is known, as it doesn't have effects.

If in such a situation we change a setting in the image tools the viewerConfig gets set with only the image tool config part and breaks the viewer, now leafing forward or backward, doesn't change the config leaving it broken.