Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afford Windows development #3419

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Apr 9, 2021

Use dev dependencies for cross-platform npm scripts.

@ghost ghost changed the title Afford windows development Afford Windows development Apr 9, 2021
@codecov-io
Copy link

Codecov Report

Merging #3419 (a5be282) into master (1b7e702) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3419   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files         196      196           
  Lines        3399     3399           
=======================================
  Hits         3024     3024           
  Misses        375      375           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7e702...a5be282. Read the comment docs.

@charbugs
Copy link
Collaborator

charbugs commented Aug 5, 2021

Hi @wwelling

thank you for your contribution 👍 I'm actually surprised that we did not recognize this lack so far.

Would you mind to give shelljs a try? It's a library and command line tool that mimics basic shell commands with Node. A script in the package.json would then look like:

"clean": "shx rm -rf ./dist",

This way we would add only one dependency instead of 4 which may be a little easier to maintain.

@charbugs charbugs self-requested a review August 5, 2021 19:55
@ghost
Copy link
Author

ghost commented Dec 23, 2021

@charbugs sorry for the very delayed response. I have looked into using shelljs (shx) but it does not have the support to set environment variables as needed. I will update to replace what dependencies I can with shelljs but cross-env is still required.

shelljs/shx#166
shelljs/shx#127

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #3419 (a5be282) into master (e7ba59a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a5be282 differs from pull request most recent head 74e9371. Consider uploading reports for the commit 74e9371 to get more accurate results

@@            Coverage Diff             @@
##           master    #3419      +/-   ##
==========================================
- Coverage   88.97%   88.96%   -0.01%     
==========================================
  Files         198      196       -2     
  Lines        3419     3399      -20     
==========================================
- Hits         3042     3024      -18     
+ Misses        377      375       -2     
Impacted Files Coverage Δ
src/components/WindowViewer.js 77.77% <0.00%> (-9.73%) ⬇️
src/components/WindowSideBarAnnotationsPanel.js 80.00% <0.00%> (-5.72%) ⬇️
src/components/ManifestRelatedLinks.js 85.71% <0.00%> (-1.79%) ⬇️
src/components/WindowSideBarCollectionPanel.js 5.00% <0.00%> (-0.27%) ⬇️
src/components/SearchPanelNavigation.js 95.83% <0.00%> (-0.17%) ⬇️
src/state/selectors/manifests.js 97.56% <0.00%> (-0.06%) ⬇️
src/components/ThumbnailNavigation.js 97.18% <0.00%> (-0.04%) ⬇️
src/i18n.js 100.00% <0.00%> (ø)
src/init.js 0.00% <0.00%> (ø)
src/config/settings.js 0.00% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ghost ghost force-pushed the cross-platform-scripts branch from 2a0e91f to fdfda3e Compare December 23, 2021 14:26
@ghost ghost force-pushed the cross-platform-scripts branch from fdfda3e to f2d2bdc Compare December 23, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants