Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annot image display through a dialog and annot list in sidebar #3435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MImranAsghar
Copy link
Contributor

@MImranAsghar MImranAsghar commented May 13, 2021

  • Display an image annotation in sidebar Canvas Annotations
  • Add annotation image dialog to display full annotation image (full size with scrolling)

Screen Shot 2021-05-13 at 10 48 30 AM

Screen Shot 2021-05-13 at 10 48 38 AM

@ggeisler
Copy link
Collaborator

Hi @MImranAsghar. This looks like nice progress on this feature, thanks for continuing to work on it. Your screenshots are helpful but is there a way you can also enable others to actually try out the feature in this PR?

The Netlify deploy-preview link doesn't appear to resolve to a preview that includes the annotation creation plugin so there isn't a way to try creating our own image annotation.

Or, if this PR is just focused on displaying an existing image annotation, there still isn't a way to see an image annotation in the deploy preview. Maybe you need to provide an example manifest that can be added to show something like your screenshots?

@MImranAsghar
Copy link
Contributor Author

MImranAsghar commented May 13, 2021

Hi! This PR is focused on displaying the created annotations. Hmm, not sure how to make it easy to view other than deploying on cloud... but I was thinking maybe you can try it out locally? I was doing that when developing.

To try out locally:

  1. Mirador folder needs to be moved under mirador-annotations
  2. In nwb.config.js, the following line can be added under 'mirador' > 'aliases':
    • 'mirador': path.resolve('./', 'mirador'),
  3. Then the usual 'npm run start' in mirador-annotations should run this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants