Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean translation in src/locales #3505

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

sideseal
Copy link
Contributor

@sideseal sideseal commented Oct 3, 2021

Hello! I was looking for various open sources for this Hacktoberfest, and I thought it was something I can do, so I simply translated it into Korean.

If there's a problem, I'll fix it quickly! Or if there's no problem, I'd really appreciate it if you could put on the "hacktoberfest-accepted" label!

It was an interesting open source contribution. Thank you!

@gigamorph
Copy link
Contributor

I reviewed the change and I can attest that the translations are sound.

As for the hacktoberfest-accepted label, it sounds like a harmless fun but I guess it is the maintainers' decision.

@sideseal
Copy link
Contributor Author

sideseal commented Oct 4, 2021

I'm glad that the translation went well!
Even if it's not labeled, it was a very meaningful work for me, so it's all okay!!

@camillevilla camillevilla self-requested a review October 28, 2021 16:44
@camillevilla
Copy link
Member

@typiespectre Thank you so much for contributing to Mirador! Hopefully we can publish a release with your translations soon.

We don't usually participate in Hacktoberfest, but please let me know if you are still trying to get your 4th PR and I will look into getting you credit by the end of the month.

@camillevilla camillevilla added the i18n translations and locale-specific issues label Oct 28, 2021
@camillevilla camillevilla merged commit 22c2ca6 into ProjectMirador:master Oct 28, 2021
@sideseal
Copy link
Contributor Author

Fortunately I've completed all the hacktoberfest PR before. 😁 Thank you for telling me so!
I'm so glad that it merged safely. I hope mirador project goes well in the future!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n translations and locale-specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants