Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context to pass the window id around #3661

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Feb 27, 2023

All the prop drilling makes it a little harder to test. Maybe context makes it easier?

@cbeer cbeer force-pushed the windowContext branch 2 times, most recently from c474cc9 to 7b0c6d3 Compare February 28, 2023 20:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #3661 (b471aeb) into master (741416d) will decrease coverage by 0.17%.
The diff coverage is 70.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3661      +/-   ##
==========================================
- Coverage   92.49%   92.33%   -0.17%     
==========================================
  Files         201      202       +1     
  Lines        3465     3483      +18     
==========================================
+ Hits         3205     3216      +11     
- Misses        260      267       +7     
Impacted Files Coverage Δ
src/components/AnnotationSettings.js 100.00% <ø> (ø)
src/components/AttributionPanel.js 80.00% <ø> (ø)
src/components/CustomPanel.js 33.33% <ø> (ø)
src/components/GalleryView.js 100.00% <ø> (ø)
src/components/IIIFAuthentication.js 94.28% <ø> (ø)
src/components/LayersPanel.js 100.00% <ø> (ø)
src/components/OpenSeadragonViewer.js 92.80% <ø> (ø)
src/components/PrimaryWindow.js 91.30% <ø> (ø)
src/components/SearchPanel.js 100.00% <ø> (ø)
src/components/SearchPanelControls.js 88.37% <ø> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants